fix(aggregations): pass dataService to redux thunk arg, fix types COMPASS-9375 #6999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabaasit
approved these changes
Jun 11, 2025
Collaborator
mabaasit
left a comment
mabaasit
left a comment
There was a problem hiding this comment.
Another ticket that this PR closes: https://jira.mongodb.org/browse/COMPASS-8508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported, Compass would break if you try to use
$outwith a database / collection that we haven't fetched yet, reason being that data service that was being used in the action wasn't actually being passed to the thunk argument and types were written in a way that hid this issue. This patch fixes the types and adds data service to the thunk arg